modules icon indicating copy to clipboard operation
modules copied to clipboard

Rattle cluster

Open chriswyatt1 opened this issue 11 months ago • 6 comments

PR checklist

Closes #XXX

  • [ x] This comment contains a description of changes (with reason).
  • [ x] If you've fixed a bug or added code that should be tested, add tests!
  • [x ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x ] If necessary, include test data in your PR.
  • [x ] Remove all TODO statements.
  • [x ] Emit the versions.yml file.
  • [x ] Follow the naming conventions.
  • [x ] Follow the parameters requirements.
  • [x ] Follow the input/output options guidelines.
  • [x ] Add a resource label
  • [ NA, no conda avail, blocked this section as done in fastk ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x ] nf-core modules test <MODULE> --profile docker
      • [x ] nf-core modules test <MODULE> --profile singularity
      • [NA< will not work as no conda env ] nf-core modules test <MODULE> --profile conda

chriswyatt1 avatar Feb 06 '25 14:02 chriswyatt1

conda will fail, as it doesn;t have a conda version to run it

chriswyatt1 avatar Feb 06 '25 14:02 chriswyatt1

@nf-core-bot fix linting

chriswyatt1 avatar Feb 08 '25 11:02 chriswyatt1

Hey @chriswyatt1, are you planning to work on this during the upcoming hackathon or would like some help to get this PR finalized?

FloWuenne avatar Mar 11 '25 02:03 FloWuenne

Sorry, I hadn't seen your message.

I have a working version, but had an issue finding a test dataset that would work with all the rattle tools

https://github.com/chriswyatt1/modules/tree/rattle_cluster

chriswyatt1 avatar Mar 25 '25 14:03 chriswyatt1

Ah, there was no conda for it. So its put as false flag that fails lint

chriswyatt1 avatar Mar 25 '25 14:03 chriswyatt1

Plus it needs to be on biocontainers:

As container = 'ecoflowucl/rattle:v1.0'

chriswyatt1 avatar Mar 25 '25 14:03 chriswyatt1

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

github-actions[bot] avatar Apr 27 '25 00:04 github-actions[bot]