modules icon indicating copy to clipboard operation
modules copied to clipboard

Add sam2lca/updadb module

Open maxibor opened this issue 1 year ago • 5 comments

And update sam2lca versions to 1.1.4

PR checklist

  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [x] nf-core modules test <MODULE> --profile singularity
      • [x] nf-core modules test <MODULE> --profile conda

maxibor avatar Nov 22 '24 14:11 maxibor

I believe your suggestions have been adressed @famosab @sateeshperi :)

maxibor avatar Dec 18 '24 13:12 maxibor

@maxibor Do you have some time to finalize this module? We are doing spring cleaning at the moment and would close if this stays inactive :)

famosab avatar Mar 11 '25 12:03 famosab

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

github-actions[bot] avatar Apr 13 '25 00:04 github-actions[bot]

@famosab Maxime is currently on holiday and moving jobs. If there are no other comments (as far as i can see), I think it's fine for you to commit your own changes and approve/merge :)

jfy133 avatar Apr 14 '25 10:04 jfy133

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

github-actions[bot] avatar May 25 '25 00:05 github-actions[bot]