modules icon indicating copy to clipboard operation
modules copied to clipboard

Fix typo in variable name in CHECKM/QA (plus some formatting fixes)

Open jfy133 opened this issue 1 year ago • 2 comments

The typo is marker_filer -> marker_file

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

jfy133 avatar Sep 20 '24 13:09 jfy133

Oh, this is pytest still? Can we swap to nf-test?

SPPearce avatar Sep 20 '24 17:09 SPPearce

Apparently 😮‍💨😮‍💨😮‍💨😮‍💨, yes I will

jfy133 avatar Sep 21 '24 08:09 jfy133

Already solved in https://github.com/nf-core/modules/pull/7119

jfy133 avatar Dec 19 '24 13:12 jfy133