modules icon indicating copy to clipboard operation
modules copied to clipboard

Fix bcftools stubs to behave like program

Open fellen31 opened this issue 1 year ago • 0 comments

This PR fixes issues where the stubs doesn't behave like the program would.

I.e. running bcftools with --output-type u/b --write-index=tbi, it still outputs a csi index, but were outputting a tbi index in the stubs:

  • --output-type v --write-index=tbi - error
  • --output-type v --write-index=csi - error
  • --output-type z --write-index=tbi - tbi index
  • --output-type z --write-index=csi - csi index
  • --output-type u --write-index=tbi - csi index <- note
  • --output-type u --write-index=csi - csi index
  • --output-type b --write-index=tbi - csi index <- note
  • --output-type b --write-index=csi - csi index

It takes the custom function added for bcftools csq in #6605, together with a similar function for the index, and applies it to the applicable modules.

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

fellen31 avatar Sep 19 '24 12:09 fellen31