modules icon indicating copy to clipboard operation
modules copied to clipboard

bumped MultiQC version for dumpsoftwareversions

Open harper357 opened this issue 1 year ago • 9 comments

PR checklist

This just updates dumpsoftwareversions to the latest version of theMultiQC container.

  • [x] This comment contains a description of changes (with reason).
  • [ ] Emit the versions.yml file.
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda

Running the test fails because the versions are updated in the container, I am not sure how you usually go about updating the test.

harper357 avatar Aug 20 '24 22:08 harper357

I wonder if this could also be replaced with the ubuntu container... I wonder if that has a basic python installation?

jfy133 avatar Aug 21 '24 18:08 jfy133

I tried to run the ubuntu container but python is not installed in it

harper357 avatar Aug 21 '24 18:08 harper357

@maxulysse pointed out that we don't use this anymore, but instead with a function in the template. He wondered if we should deprecate it.

jfy133 avatar Aug 22 '24 08:08 jfy133

So, do we want to deprecate this?

SPPearce avatar Sep 16 '24 09:09 SPPearce

I don't know if we have a deprecation procedure do we?

jfy133 avatar Sep 16 '24 09:09 jfy133

I don't know if we have a deprecation procedure do we?

Oh James, I thought you knew the guidelines 😉.

SPPearce avatar Sep 16 '24 13:09 SPPearce

I don't know if we have a deprecation procedure do we?

Oh James, I thought you knew the guidelines 😉.

OH nice! Then yes, lets deprecate :)

jfy133 avatar Sep 18 '24 08:09 jfy133

Added a message. I don't know what happens to the tests at that point, but they seem to be fine for the other modules so maybe they just ignore the assert?

SPPearce avatar Sep 18 '24 08:09 SPPearce

@jfy133 @SPPearce @harper357 Can we finish this PR somehow?

famosab avatar Mar 11 '25 13:03 famosab