modules icon indicating copy to clipboard operation
modules copied to clipboard

Add Seurat/MULTI-seq

Open mari-ga opened this issue 1 year ago • 1 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [x] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

mari-ga avatar Aug 13 '24 13:08 mari-ga

  1. MULTI-seq is a hashing demultiplexing module from Seurat. I created the structure Seurat/Multi-seq because I intend to add another hashing demultiplexing module to the folder, which is also the property of Seurat (HTODemux), so both tools from the same library are located in the same place. Is that right?
  2. These modules need many arguments to run its different functionalities, which I added in the nextflow.config file, any suggestion about this? especially, regarding the tests
  3. also the code used to generate the plots for both tools is very very similar, any suggestion about it?

mari-ga avatar Aug 13 '24 14:08 mari-ga

Hi @mari-ga . I'm back to having a little bit of spare time to look at nf-core things again, I'll try and take a proper look today.

SPPearce avatar Nov 05 '24 08:11 SPPearce

@mari-ga @SPPearce Is this PR still relevant? :)

luisas avatar Mar 11 '25 13:03 luisas

@mari-ga @SPPearce Is this PR still relevant? :)

Uhhh, that one would be on me, looks like I was supposed to be reviewing it and forgot 😞 Apologies @mari-ga , are you still working on this?

SPPearce avatar Mar 11 '25 13:03 SPPearce