modules icon indicating copy to clipboard operation
modules copied to clipboard

mulled biocontainer for vardict-java and htslib

Open eolaniru opened this issue 1 year ago • 3 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

eolaniru avatar Jul 04 '24 11:07 eolaniru

ah, brilliant! thanks @nvnieuwk. Not sure where the args2 will go :)

eolaniru avatar Jul 04 '24 11:07 eolaniru

You can add it after the bgzip command. Make sure you create the variable too, similar to args

nvnieuwk avatar Jul 04 '24 11:07 nvnieuwk

You should also fix the tests since you have a new output format. You can do this with nf-core modules test vardictjava --update

nvnieuwk avatar Jul 04 '24 13:07 nvnieuwk