modules icon indicating copy to clipboard operation
modules copied to clipboard

new module: yte

Open famosab opened this issue 1 year ago • 2 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

I still need to check how params are handed to yte. Hence this is a draft PR until that is clarified. I will also add tests then.

famosab avatar Jun 26 '24 14:06 famosab

Yte is being extended to allow the use of templates via the CL: https://github.com/yte-template-engine/yte/pull/44

famosab avatar Aug 02 '24 08:08 famosab

I would leave this open, still need to clarify some things with the yte developer.

famosab avatar Mar 10 '25 09:03 famosab

There is still an issue with the conda-forge package but as soon as that is solved I think this module is finally finished. See https://github.com/conda-forge/yte-feedstock/pull/33

famosab avatar Jul 14 '25 09:07 famosab

Or we leave it with pip (would also be fine for me). And then we just need to merge the test-datasets and update the test filepaths

famosab avatar Jul 14 '25 09:07 famosab

Perfect, I'll merge as is and update as soon as the conda-forge package becomes available again.

famosab avatar Jul 15 '25 07:07 famosab