First Neuroimaging module : denoising/nlmeans

[AlexVCaron]

PR checklist

• [ ] This comment contains a description of changes (with reason).
• [x] If you've fixed a bug or added code that should be tested, add tests!
• [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
• [x] If necessary, include test data in your PR.
• [x] Remove all TODO statements.
• [x] Emit the versions.yml file.
• [x] Follow the naming conventions.
• [ ] Follow the parameters requirements.
• [ ] Follow the input/output options guidelines.
• [x] Add a resource label
• [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
• Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
  • For modules:
    • [x] nf-core modules test <MODULE> --profile docker
    • [x] nf-core modules test <MODULE> --profile singularity
    • [ ] nf-core modules test <MODULE> --profile conda
  • For subworkflows:
    • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
    • [x] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
    • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

[edmundmiller]

As I mentioned in the tools issue, I changed my opinion on it after some pushback.

Some ideas are:

1. modules/nf-core/scil/denoisingnlmeans
2. modules/nf-core/scil/denoising_nlmeans
3. modules/nf-core/scil/denoising/nlmeans

Main focus being not creating a lot of infrastructure work surrounding this adoption. 1 will definitely work, 2 and 3 may not with either the new containers workflows or linting but if the naming and organization is more appealing you're welcome to try!

[famosab]

I would go for modules/nf-core/scil/denoisingnlmeans

Do you still plan to finish this? @AlexVCaron

[github-actions[bot]]

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

[github-actions[bot]]

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.

[vagkaratzas]

Is this being worked on or shall we close for now?

[github-actions[bot]]

This PR has been tagged as awaiting-changes or awaiting-feedback by an @nf-core/modules contributor. Remove stale label or add a comment if it is still useful.