modules icon indicating copy to clipboard operation
modules copied to clipboard

Stub and nf-test for fastk/fastk

Open GallVp opened this issue 1 year ago • 1 comments

PR checklist

Closes #XXX

  • [x] Stub and nf-test for fastk/fastk
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

GallVp avatar May 18 '24 07:05 GallVp

Strange!

I had to add

find . -name '*.ktab*' \
    | xargs chmod +r

to get it working on docker_self_hosted. Somehow, FASTK is messing with the file permissions on ktab files on docker self hosted. Does not happen on my MacBook/macOS/docker.

GallVp avatar May 20 '24 03:05 GallVp

I don't know what's going on with the self hosted workers really, but Docker on Mac is running through a VM of sorts that corrects permissions even when it's run as root. I would check the user is supplied in the runner here.

( and thanks for updating the tests )

mahesh-panchal avatar May 20 '24 12:05 mahesh-panchal

nf-core/slack post: https://nfcore.slack.com/archives/CJRH30T6V/p1716244157631629

GallVp avatar May 20 '24 22:05 GallVp