modules icon indicating copy to clipboard operation
modules copied to clipboard
verified publisher icon nf-core

New attempt to add merfin/hist module

Open rodtheo opened this issue 2 years ago • 1 comments

PR checklist

Closes #5136

  • [X] This PR implements the module merfin/hist. Its a new attempt after incorporating suggestions mentioned in #5300.
  • [X] If you've fixed a bug or added code that should be tested, add tests!
  • [X] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [X] If necessary, include test data in your PR.
  • [X] Remove all TODO statements.
  • [X] Emit the versions.yml file.
  • [X] Follow the naming conventions.
  • [X] Follow the parameters requirements.
  • [X] Follow the input/output options guidelines.
  • [X] Add a resource label
  • [X] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [X] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

rodtheo avatar Mar 20 '24 17:03 rodtheo

@itrujnara, any chances to review it again? Thanks for considering my request.

rodtheo avatar Mar 21 '24 17:03 rodtheo

Thanks for updating the stubs

I'm glade to contribute! However I'm still getting an error related to genomescope2 running tests in conda environment. Any tips on why this is happening?

rodtheo avatar Mar 26 '24 12:03 rodtheo

Thanks for updating the stubs

I'm glade to contribute! However I'm still getting an error related to genomescope2 running tests in conda environment. Any tips on why this is happening?

I'm not entirely clear, but I'm going to make a PR to your branch at some point in the coming days to try and fix the test.

mahesh-panchal avatar Mar 26 '24 12:03 mahesh-panchal

https://github.com/nf-core/modules/pull/5401 should also remove the need to have the fixes for the linting checks here. You've been added as co-author on the relevant commits in those other PRs.

mahesh-panchal avatar Mar 26 '24 20:03 mahesh-panchal

Nice work. Thank you. Sorry about all the changes.

No worries, thank you for your valuable tips and suggestions. I've learned a lot.

rodtheo avatar Apr 02 '24 18:04 rodtheo