modules icon indicating copy to clipboard operation
modules copied to clipboard

Add popscle/demuxlet to module

Open wxicu opened this issue 1 year ago • 4 comments

Add single-cell demultiplexing tool demuxlet to module

PR checklist

Closes #5073

  • [x] This comment contains a description of changes (with reason).
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [ ] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [x] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

wxicu avatar Mar 20 '24 09:03 wxicu

I believe this code does not belong here, it looks like a separate module that needs its own PR (I mean, the dsc-pileup code)

the dsc-pileup is required to provide the optional input for demuxlet. Is it better to make it separate from this PR?

wxicu avatar Mar 20 '24 14:03 wxicu

I believe this code does not belong here, it looks like a separate module that needs its own PR (I mean, the dsc-pileup code)

the dsc-pileup is required to provide the optional input for demuxlet. Is it better to make it separate from this PR?

Even though it is referenced by this one, it's a module in its own right and I believe it should be processed separately (e.g. because it will be easier to review one module at a time). Can you please create a PR for pileup, and return to this one once it is approved? You can ping me for review on the new PR if you need

itrujnara avatar Mar 20 '24 14:03 itrujnara

sure, will do this

wxicu avatar Mar 20 '24 14:03 wxicu

Hi, this is just to remind you that you can now finish this PR. Ping me once you've cleaned all the files here.

itrujnara avatar Mar 21 '24 10:03 itrujnara