modules icon indicating copy to clipboard operation
modules copied to clipboard

Added custom/shortenfastaids

Open GallVp opened this issue 1 year ago • 3 comments

PR checklist

Closes #XXX

  • [x] Added custom/shortenfastaids for https://github.com/nf-core/modules/pull/4984
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • [x] nf-core modules test <MODULE> --profile docker
      • [ ] nf-core modules test <MODULE> --profile singularity
      • [ ] nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • [ ] nf-core subworkflows test <SUBWORKFLOW> --profile conda

GallVp avatar Feb 26 '24 20:02 GallVp

Have you checked there are no other modules in nf-core modules that can provide this functionality?

mahesh-panchal avatar Feb 27 '24 08:02 mahesh-panchal

Google searches are leading me to custom scripts.

GallVp avatar Feb 27 '24 20:02 GallVp

What about https://www.nextflow.io/docs/latest/operator.html#splitfasta. Can this operator replace this module in the subworkflow? For example, specifically using the record: [ id: true] or perhaps text or desc are relevant. Also this can work on files too using the map operator.

mahesh-panchal avatar Feb 28 '24 08:02 mahesh-panchal

Replaced with Groovy code, see #4984

GallVp avatar Jun 05 '24 02:06 GallVp