modules icon indicating copy to clipboard operation
modules copied to clipboard

adding chewbbaca/createschema module

Open anwarMZ opened this issue 2 years ago • 6 comments

PR checklist

Closes #4480

  • [-] This comment contains a description of changes (with reason).
  • [-] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [-] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [ ] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [x] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

anwarMZ avatar Nov 29 '23 17:11 anwarMZ

Thanks to @rpetit3 for his feedback and suggestions

anwarMZ avatar Nov 29 '23 18:11 anwarMZ

It seems like the nf-core lint tests are failing because the meta map is not emitted as output channel. This should be emitted as well, to allow other modules downstream to also use the meta map.

ggabernet avatar Dec 06 '23 01:12 ggabernet

It seems like the nf-core lint tests are failing because the meta map is not emitted as output channel. This should be emitted as well, to allow other modules downstream to also use the meta map.

Thanks for finding that. I have updated the output to emit meta map.

anwarMZ avatar Dec 06 '23 18:12 anwarMZ

can you kindly add nf-tests for this module docs guidelines

@sateeshperi thank you for your feedback, I have updated the module. This is my first nf-test writing experience, I am running into a failed test. Can you provide some help with this? Thanks

anwarMZ avatar Jan 05 '24 22:01 anwarMZ

@sateeshperi I updated the stub to create an "n" number of files based on the number of genes and proteins, given that it can be much higher than 20 for bacterial genomes.

I am still failing the test for stub ... looking into it

anwarMZ avatar Jan 08 '24 21:01 anwarMZ

@anwarMZ, do you need some help to finish this PR off?

SPPearce avatar May 06 '24 15:05 SPPearce

Thanks @JoseEspinosa

SPPearce avatar Jul 02 '24 15:07 SPPearce

Thanks for taking this to the finish line @SPPearce I got pulled into other things in the last little while.

anwarMZ avatar Jul 02 '24 17:07 anwarMZ

No worries @anwarMZ . I swapped the allelecall module to nf-test, but I don't know what it actually wants as input and whether we have it currently available as test data, but we can talk about that on the other PR.

SPPearce avatar Jul 02 '24 18:07 SPPearce