modules icon indicating copy to clipboard operation
modules copied to clipboard

Newmodule verkko 3

Open scorreard opened this issue 2 years ago • 1 comments

This new module was created for Verkko

It only includes the option to use PacBio reads.

To be able to use ONT (nano-ore) reads, we have to wait for the release of their next version as an issue was addressed (See https://github.com/marbl/verkko/issues/185 for details)

PR checklist

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [ ] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

scorreard avatar Oct 18 '23 20:10 scorreard

also could you explore creating nf-tests for this module docs: https://nf-co.re/docs/contributing/modules#migrating-from-pytest-to-nf-test

sateeshperi avatar Dec 08 '23 13:12 sateeshperi

Closing this PR without merging as a lot of changes were made to module creation and nf-test, I think it would be better to strat from scratch

scorreard avatar Jun 13 '24 15:06 scorreard