modules icon indicating copy to clipboard operation
modules copied to clipboard

Fix documentation link

Open pbiology opened this issue 2 years ago • 2 comments

This PR corrects a link found in two of the bwa modules meta.yml file. They did incorrectly point to a samtools website.

PR checklist

  • [x] This comment contains a description of changes (with reason).
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [x] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [x] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [x] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

pbiology avatar Aug 24 '23 12:08 pbiology

I'm not sure how to proceed with these tests which are failing. Any input @mashehu ?

pbiology avatar Aug 28 '23 08:08 pbiology

the conda ones are probably okay to ignore, the sha sum is often not reproducible with conda. Can you try to update the ones for sapme? I know you didn't touch the code itself, but it's always good if we try to fix the tests when they somehow start failing

mashehu avatar Sep 25 '23 11:09 mashehu