modules icon indicating copy to clipboard operation
modules copied to clipboard

Update params dependencies into value input channels #2982

Open vucka opened this issue 2 years ago • 3 comments

PR checklist

Closes #XXX

  • [ ] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [ ] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [ ] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

vucka avatar Mar 27 '23 13:03 vucka

Hi @vucka can you rename the title, I feel like it doesn't correspond to what is actually happening in the PR

maxulysse avatar Mar 30 '23 13:03 maxulysse

@vucka any chance you can try and fix the merge conflicts?

maxulysse avatar Oct 17 '23 13:10 maxulysse

There are now 12 conflicted files, I'm struggling to see how to reconcile this and what the real changes actually are, so I'm minded to close this PR.

SPPearce avatar May 09 '24 09:05 SPPearce