modules icon indicating copy to clipboard operation
modules copied to clipboard

New Subworkflow: Bam_trim_primers_ivar

Open Joon-Klaps opened this issue 2 years ago • 3 comments

PR checklist

Addresses first bullet from https://github.com/nf-core/viralrecon/issues/371

adds the subworkflow bam_trim_primers_ivar used in nf-core/viralrecon to nf-core/modules

  • [X] This comment contains a description of changes (with reason).
  • [X] If you've fixed a bug or added code that should be tested, add tests!
  • [X] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] Remove all TODO statements.
  • [X] Emit the versions.yml file.
  • [X] Follow the naming conventions.
  • [X] Follow the parameters requirements.
  • [X] Follow the input/output options guidelines.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [X] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

Joon-Klaps avatar Mar 27 '23 13:03 Joon-Klaps

Not Sure why conda test is failing though..

Joon-Klaps avatar Mar 28 '23 09:03 Joon-Klaps

It seems to be something tool specific. Maybe a wrong conda package?

nvnieuwk avatar Mar 28 '23 09:03 nvnieuwk

It seems to be something tool specific. Maybe a wrong conda package?

Yeah... doesn't seem something I'll be able to finish as part of this PR... https://github.com/andersen-lab/ivar/issues/93

Joon-Klaps avatar Mar 28 '23 13:03 Joon-Klaps