modules icon indicating copy to clipboard operation
modules copied to clipboard

Module: ichorcna/run updated to v0.5.0

Open adamrtalbot opened this issue 2 years ago • 8 comments

Changes:

  • ichorcna no longer has a CLI, so it has been updated to use native R
  • Some additional parameters have been added
  • Requires scStates option in nextflow.config or it crashes

PR checklist

  • [x] This comment contains a description of changes (with reason).
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [x] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

adamrtalbot avatar Jan 23 '23 16:01 adamrtalbot

@nf-core-bot fix linting

adamrtalbot avatar Jan 31 '23 15:01 adamrtalbot

Looks generally good, few minor points. Is the meta.yml not updated? Presumably that still points at the old broad institute github link.

SPPearce avatar Feb 01 '23 08:02 SPPearce

@nf-core-bot fix linting

adamrtalbot avatar Mar 07 '23 09:03 adamrtalbot

Nothing for me to do here! :shrug: This is probably because the linting errors come from nf-core lint and have to be fixed manually (or with nf-core lint --fix).

github-actions[bot] avatar Mar 07 '23 09:03 github-actions[bot]

@nf-core-bot fix linting

adamrtalbot avatar Mar 07 '23 13:03 adamrtalbot

Hey @adamrtalbot , shall we get this finished off and merged in?

SPPearce avatar Oct 02 '23 12:10 SPPearce

Hey @adamrtalbot , shall we get this finished off and merged in?

What do we need to do? I need a ✅ review to get this merged.

adamrtalbot avatar Oct 02 '23 13:10 adamrtalbot

I have a half-done conversion to nf-test actually

SPPearce avatar Jun 28 '24 14:06 SPPearce

Superceded by #6079 as I couldn't edit Adam's branch.

SPPearce avatar Aug 06 '24 09:08 SPPearce