modules icon indicating copy to clipboard operation
modules copied to clipboard

Configure testing with Podman and Mamba

Open TomKellyGenetics opened this issue 3 years ago • 5 comments

Implements unit testing and GitHub Actions with Podman. Migrates changes in PR #1706 for separate discussion.

Note that Mamba has also been proposed as an alternative to Conda in PR #2610.

PR checklist

  • [x] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [ ] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [ ] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [ ] Emit the versions.yml file.
  • [ ] Follow the naming conventions.
  • [ ] Follow the parameters requirements.
  • [ ] Follow the input/output options guidelines.
  • [ ] Add a resource label
  • [ ] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [ ] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=podman pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=mamba pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

TomKellyGenetics avatar Dec 16 '22 13:12 TomKellyGenetics

I don't think the mamba support is necessary either, given: https://www.anaconda.com/blog/conda-is-fast-now

jfy133 avatar Dec 20 '22 09:12 jfy133

This branch will have to be rebased to include the changes made in #2740

muffato avatar Jan 17 '23 21:01 muffato

Updates as requested. Thanks for taking this proposal into consideration.

TomKellyGenetics avatar Jan 18 '23 08:01 TomKellyGenetics

Same as other, don't think it's necessary

maxulysse avatar Jan 18 '23 09:01 maxulysse

So, do we want to implement Podman and Mamba or do we want to close this PR?

SPPearce avatar May 09 '24 09:05 SPPearce