modules icon indicating copy to clipboard operation
modules copied to clipboard

Published 20 hours ago • verified publisher icon nf-core

Cardinality of MALT_BUILD

Open chriswyatt1 opened this issue 2 years ago • 2 comments

Contributes to #2154

cardinality was wrong for the MALT_BUILD test (needs 5 inputs), have changed this to what I feel is the default (see below), and run nf-core modules test, and there are no failed jobs.

See line 27 of main.nf:

MALT_BUILD ( fastas, seq_type, UNZIP_MALT.out.unzipped_archive.map{ it[1] } )

changed to:

MALT_BUILD ( fastas, seq_type, UNZIP_MALT.out.unzipped_archive.map{ it[1] } , "ref" , "taxonomy" )

chriswyatt1 avatar Oct 11 '22 15:10 chriswyatt1

@nf-core-bot fix linting

SPPearce avatar Oct 12 '22 06:10 SPPearce

@nf-core-bot fix linting

JoseEspinosa avatar Oct 12 '22 07:10 JoseEspinosa

Can you remove the md5sums of the empty files from test.yml? @chriswyatt1

nvnieuwk avatar Oct 24 '22 14:10 nvnieuwk

Given these are both modules I'll add, I will take the liberty to fix them on @chriswyatt1 's branch

jfy133 avatar Oct 25 '22 06:10 jfy133

Tests are failing :fearful:

nvnieuwk avatar Oct 25 '22 06:10 nvnieuwk

Yes.. happening locally for me too... trying to debug...

jfy133 avatar Oct 25 '22 06:10 jfy133

🙄

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>301 Moved Permanently</title>
</head><body>
<h1>Moved Permanently</h1>
<p>The document has moved <a href="http://software-ab.cs.uni-tuebingen.de/download/megan6/nucl_acc2tax-Jul2019.abin.zip">here</a>.</p>
<hr>
<address>Apache/2.4.41 (Ubuntu) Server at software-ab.informatik.uni-tuebingen.de Port 443</address>
</body></html>

jfy133 avatar Oct 25 '22 07:10 jfy133

Thanks @chriswyatt1 @SPPearce @JoseEspinosa @nvnieuwk !

jfy133 avatar Oct 25 '22 08:10 jfy133