modules icon indicating copy to clipboard operation
modules copied to clipboard

fix #2095 - new module verifybamid/verifybamid legacy

Open manifestoso opened this issue 2 years ago • 2 comments

PR checklist

Closes #2095

  • [x] This comment contains a description of changes (with reason).
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [ ] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [ ] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

manifestoso avatar Oct 11 '22 09:10 manifestoso

Please check all TODOs are removed first :)

jfy133 avatar Oct 11 '22 10:10 jfy133

Please check all TODOs are removed first :)

thx @jfy133, just come back to this. lint fixed.

manifestoso avatar Oct 11 '22 20:10 manifestoso

Have another look @jfy133?

manifestoso avatar Nov 29 '22 06:11 manifestoso

@manifestoso you can pull upstream from master and merge :+1:

jfy133 avatar Nov 30 '22 06:11 jfy133