modules
modules copied to clipboard
updating the sourmash sketch module
This PR updates the sourmash sketch module.
In main.nf:
- upgrades to the latest version of sourmash (4.5.0)
- updates the params string to the standard set of parameters typically used by sourmash (including to sketch all of GenBank and the SRA). The test data should stay the same, and the way the param string is parameterized hasn't changed so can still be updated to the user if they wish to not follow this convention.
In meta.yml:
- updates the doi to the correct citation (currently listed as mash, which is a different tool than sourmash)
- updates the url to the correct sourmash github repo
- updates the description from MinHash to FracMinHash
- updates the types of data ingested to include protein sequences, transcriptomes, and fastq files
PR checklist
- [X] This comment contains a description of changes (with reason).
- [ ] Follow the parameters requirements.
- [x] Add a resource
label - [X] Use BioConda and BioContainers if possible to fulfil software requirements.
- Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
- [x]
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware - [x]
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware - [x]
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
- [x]
I'm not sure what the checklist item about following parameter requirements refers to so I didn't check that box for now.