modules icon indicating copy to clipboard operation
modules copied to clipboard

Add gatk cnvcaller

Open ryanjameskennedy opened this issue 2 years ago • 2 comments

PR checklist

Adds gatk's germline cnv caller modules (PreprocessIntervals, CollectReadCounts, AnnotateIntervals, FilterIntervals) and the respective test files

  • [x] This comment contains a description of changes (with reason).
  • [x] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the module conventions in the contribution docs
  • [x] If necessary, include test data in your PR.
  • [x] Remove all TODO statements.
  • [x] Emit the versions.yml file.
  • [x] Follow the naming conventions.
  • [x] Follow the parameters requirements.
  • [x] Follow the input/output options guidelines.
  • [x] Add a resource label
  • [x] Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • [x] PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [x] PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • [x] PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

ryanjameskennedy avatar Jun 10 '22 11:06 ryanjameskennedy

Some of gatk's germline cnv caller modules (PreprocessIntervals, CollectReadCounts, AnnotateIntervals, FilterIntervals) and the respective test files were added. Other modules (DetermineGermlineContigPloidy, GermlineCNVCaller, PostProcessGermlineCNVCalls) are unable to be tested as the biocontainers used by nf-core for Singularity and Docker do not contain gcnvkernel.

ryanjameskennedy avatar Jun 10 '22 13:06 ryanjameskennedy

@ryanjameskennedy small tip for the future: it would be good to split these up into one PR per module as you will get speedier responses from more people, having to review so many modules in one go will put a lot of people off

jfy133 avatar Jul 06 '22 09:07 jfy133

@ryanjameskennedy what's the status on this PR?

nvnieuwk avatar Oct 25 '22 11:10 nvnieuwk

It's not yet finished, I have changed it's status to a draft.

ryanjameskennedy avatar Oct 25 '22 12:10 ryanjameskennedy