modules icon indicating copy to clipboard operation
modules copied to clipboard

[FEATURE] Fix bioconda recipe for deepvariant

Open maxulysse opened this issue 3 years ago • 5 comments

Latest release is 1.1.0. Latest available on bioconda is: 1.0.0

maxulysse avatar Feb 19 '21 09:02 maxulysse

Hi @maxulysse

As some background work for nf-core/sarek#394 I had a look at the deepvariant container available in biocontainers and conda, however they don't bundle the run_deepvariant.py wrapper utility which was released last year.

For the purpose of the module, I'm relying on Google's container for deepvariant and once the module design is finalized, I'll try to accomodate those changes in conda version of deepvariant recipe.

abhi18av avatar Jul 06 '21 16:07 abhi18av

Hey @abhi18av ! What is the status here?

FriederikeHanssen avatar Oct 26 '21 13:10 FriederikeHanssen

Hi @FriederikeHanssen ,

This is a tough nut, I have initiated an issue on the bioconda side https://github.com/bioconda/bioconda-recipes/issues/30310 and taken a stab at the recipe here https://github.com/bioconda/bioconda-recipes/pull/30311/files, however I found the build script to be a bit convoluted and contacted the core authors through the issue.

Haven't heard back from them regarding the inclusion of run_deepvariant script. However, on the nf-core/modules side (https://github.com/nf-core/modules/pull/572 ) the docker and singularity builds directly use the official Google containers which are passing the tests.

abhi18av avatar Oct 26 '21 13:10 abhi18av

ok, then let's leave this issue open :) Thank you, I tried to clean up a bit before tomorrow

FriederikeHanssen avatar Oct 26 '21 13:10 FriederikeHanssen

Should we move this issue to modules? Not exactly a sarek related one

FriederikeHanssen avatar Jun 10 '22 07:06 FriederikeHanssen