methylseq icon indicating copy to clipboard operation
methylseq copied to clipboard

Support for NuGen Ovation RRBS libraries

Open jma1991 opened this issue 1 year ago • 3 comments

This pull request introduces an initial implementation for processing NuGen Ovation RRBS libraries, drawing guidance from the commands outlined in the NuMetRRBS repository. Currently, the focus is on integrating fundamental steps such as adapter trimming and diversity trimming. Although there's an optional component for deduplicating reads via molecular tags, I'm not sure how to implement this right now. Lastly, let me know if I should submit some Ovation data to the test-datasets repository.

PR checklist

  • [x] This comment contains a description of changes (with reason).
  • [ ] If you've fixed a bug or added code that should be tested, add tests!
  • [x] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • [ ] If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • [ ] Make sure your code lints (nf-core lint).
  • [ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [ ] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • [x] Usage Documentation in docs/usage.md is updated.
  • [x] Output Documentation in docs/output.md is updated.
  • [ ] CHANGELOG.md is updated.
  • [x] README.md is updated (including new tool citations and authors/contributors).

jma1991 avatar Feb 14 '24 14:02 jma1991

The suggested diversity trimming looks good to me, but do we have specific test data for this?

I have some Ovation test data, shall I submit it to the test-datasets repository?

jma1991 avatar Feb 27 '24 11:02 jma1991

@jma1991 could you please update / rebase this PR off the latest nf-core dev branch please?

ewels avatar Feb 27 '24 12:02 ewels

@jma1991 checking in here - did you get some test data into the test-datasets repo ?

sateeshperi avatar Sep 17 '24 16:09 sateeshperi