methylseq icon indicating copy to clipboard operation
methylseq copied to clipboard

Hs metrics

Open RogerHw opened this issue 2 years ago • 5 comments

The module: collecthsmetrics is now available from modules/nf-core

RogerHw avatar May 26 '23 17:05 RogerHw

This PR is against the master branch :x:

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @RogerHw,

It looks like this pull-request is has been made against the RogerHw/Trainee master branch. The master branch on nf-core repositories should always contain code from the latest release. Because of this, PRs to master are only allowed if they come from the RogerHw/Trainee dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page. Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

github-actions[bot] avatar May 26 '23 17:05 github-actions[bot]

@RogerHw quick question, have you used nf-core tools to install the new module? as i am not seeing those files other than addition to modules.json

sateeshperi avatar May 30 '23 14:05 sateeshperi

@RogerHw quick question, have you used nf-core tools to install the new module? as i am not seeing those files other than addition to modules.json

Hi! I'm sorry, I´m new at Git / Nextflow, I did the pull request in the main but I actually wanted to do it in the dev branch. Yes I installed th HS metrics module with nf-core tools, is just that I didn't upload the files.

RogerHw avatar May 30 '23 14:05 RogerHw

cool...let me help you....now your PR is against dev so that's good. some of the next steps are:

  1. git pull current dev and make sure it is up to date
  2. finish making your changes then run prettier --check . and nf-core lint
  3. make sure all lint tests pass and commit your changes and push

you can reach out on nf-core slack #methylseq channel if you need more help

sateeshperi avatar May 30 '23 14:05 sateeshperi

cool...let me help you....now your PR is against dev so that's good. some of the next steps are:

  1. git pull current dev and make sure it is up to date
  2. finish making your changes then run prettier --check . and nf-core lint
  3. make sure all lint tests pass and commit your changes and push

you can reach out on nf-core slack #methylseq channel if you need more help Sure! thank you so much :)

RogerHw avatar May 30 '23 14:05 RogerHw