fetchngs icon indicating copy to clipboard operation
fetchngs copied to clipboard

why does input file need to end in .txt

Open ojziff opened this issue 3 years ago • 1 comments

Description of the bug

minor point, but why does --input have to match pattern ^\S+.txt$ Since the input is just a single column of SRR identifiers, it could be csv or tsv.

Command used and terminal output

nextflow run nf-core/fetchngs \
--input srr_id.txt \
--outdir reads \
--force_sratools_download -profile crick -r 1.7 -resume

Referring to: see https://github.com/nf-core/fetchngs/blob/b79cde2fb58ec3bee3ef20124c6ade0c2f263d7d/nextflow_schema.json#L19 and https://github.com/nf-core/fetchngs/blob/0c43cc787290d88c9127af8281bb69554d905012/nextflow_schema.json#L21

ojziff avatar Oct 18 '22 20:10 ojziff

I don't see a good reason. Was there one that I forgot about @drpatelh ?

Midnighter avatar Oct 19 '22 10:10 Midnighter

Somewhat a duplicate of https://github.com/nf-core/fetchngs/issues/111

drpatelh avatar Nov 02 '22 10:11 drpatelh

Fixed in https://github.com/nf-core/fetchngs/pull/115/commits/d67b3ef6eaf437c7a22da800fcb0d26f19d0a9a7

drpatelh avatar Nov 04 '22 11:11 drpatelh