fetchngs icon indicating copy to clipboard operation
fetchngs copied to clipboard

Implement ffq

Open drpatelh opened this issue 3 years ago • 2 comments

First pass implementation to use ffq to fetch metadata from public databases.

drpatelh avatar Jun 30 '22 20:06 drpatelh

nf-core lint overall result: Passed :white_check_mark: :warning:

Posted for pipeline commit 4506619

+| ✅ 143 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!

:heavy_exclamation_mark: Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • nextflow_config - Config manifest.version should end in dev: '1.7'
  • readme - README did not have a Nextflow minimum version badge.

:grey_question: Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

:white_check_mark: Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-01 16:22:50

github-actions[bot] avatar Jun 30 '22 20:06 github-actions[bot]

Tests are expected to fail here due to recent breaking changes introduces in the NCBI API.

The plan is to try and get the tests passing again using ffq instead and to try and maintain feature parity with the existing release in terms of the samplesheet output and id compatibility.

drpatelh avatar Jun 30 '22 20:06 drpatelh