configs icon indicating copy to clipboard operation
configs copied to clipboard

[WIP] Add Institute-specific genomes!!

Open drpatelh opened this issue 3 years ago • 7 comments

I have now tested this with the rnaseq pipeline (v3.0) on my own fork. This means we can have remote genome configs for each Institution so all users can just provide a --genome key from their own genomes.config and the files can be shared across all users saving the need to duplicate the data across your storage!!!

Since this file is on nf-core/configs if you have/add your Institutional profile here then these configs will be pulled dynamically when you run any nf-core pipeline meaning that if you update the genomes file here then that will be observed immediately for all users too i.e. saving the need to change this manually across multiple users.

Still fascinated that this repo is still working since we first put this together a couple of years ago. Being able to use remote genomes is now a massive bonus too!

drpatelh avatar Dec 18 '20 15:12 drpatelh

I do like this idea.

I think you're only missing a bit more information in the crick.md file, like on the CAMP specific genomes ;-)

maxulysse avatar Dec 18 '20 16:12 maxulysse

We will be adding more genomes in the future @MaxUlysse . I mainly want to get this in so users can test it properly. Will definitely add docs then 👍🏽 Also move the pipeline specific params as you suggested.

drpatelh avatar Dec 18 '20 16:12 drpatelh

We will be adding more genomes in the future @MaxUlysse . I mainly want to get this in so users can test it properly. Will definitely add docs then 👍🏽 Also move the pipeline specific params as you suggested.

I'm afraid you also need to add the specific part in the rnaseq pipeline cf https://github.com/nf-core/configs/#adding-a-new-pipeline-specific-config.

So you can actually keep it the way it was until you make a new release ;-)

maxulysse avatar Dec 18 '20 16:12 maxulysse

Ah dammit! Good spot. Ok, will revert it back.

drpatelh avatar Dec 18 '20 16:12 drpatelh

Done @MaxUlysse ! This custom rnaseq stuff has already been fixed for the next release anyway :)

drpatelh avatar Dec 18 '20 16:12 drpatelh

@drpatelh / @chris-cheshire - is this PR still alive?

ewels avatar Nov 18 '21 23:11 ewels

POC so will convert to draft.

drpatelh avatar Nov 19 '21 07:11 drpatelh

@drpatelh Given this is 4 years old, I'm leaning towards closing it and asking oyu to start from scrach.

Will give you a week to think about it!

jfy133 avatar May 15 '24 10:05 jfy133

@drpatelh Given this is 4 years old, I'm leaning towards closing it and asking oyu to start from scrach.

Will give you a week to think about it!

I'd say we kill it

maxulysse avatar May 16 '24 09:05 maxulysse

Not heard back otherwise, closing!

jfy133 avatar May 22 '24 08:05 jfy133