bacass icon indicating copy to clipboard operation
bacass copied to clipboard

Add flye to nf-core/bacass

Open lborcard opened this issue 1 year ago • 12 comments

lborcard avatar Mar 18 '24 10:03 lborcard

It would be great to have flye in here, but I do want to highlight that currently a template update would be really necessary.

d4straub avatar Mar 18 '24 12:03 d4straub

I'm on it, @d4straub! 👍🏾 I'm encountering a bit of trouble getting the latest template update to work in nf-core/bacass.

Daniel-VM avatar Mar 18 '24 12:03 Daniel-VM

In addition, I would like to mention that we need to consider implementing Flye because it can already be accessed through the Dragonflye module, which is already implemented but in the development branch. I have to make a release ASAP 🏃🏾 .

Daniel-VM avatar Mar 18 '24 12:03 Daniel-VM

Ok thanks @Daniel-VM , I am now working on adding Flye, it's my first time contributing to nf-core, I was looking for guidance as waht is necessary to do.

lborcard avatar Mar 18 '24 13:03 lborcard

Awesome @lborcard. We have other interesting approaches in mind re: #57 . For example, improving assembled genomes by adding a genome rotation step. We proposed here cyclator or dnaapler or both.

Should we try them? (Feel free to open a new issue to cover this genome rotation task 😃 )

Daniel-VM avatar Mar 18 '24 14:03 Daniel-VM

Awesome @lborcard. We have other interesting approaches in mind re: #57 . For example, improving assembled genomes by adding a genome rotation step. We proposed here cyclator or dnaapler or both.

Should we try them? (Feel free to open a new issue to cover this genome rotation task 😃 )

It seems that dnaapler is more recent and recently maintained but I don't have experience with either of these tools.

lborcard avatar Mar 19 '24 08:03 lborcard

So dnaapler/cyclator would take the output of Dragonflye? is there a module for either of these tools?

lborcard avatar Mar 19 '24 08:03 lborcard

Dragonflye is already present as module

jenmuell avatar Mar 19 '24 08:03 jenmuell

So dnaapler/cyclator would take the output of Dragonflye? is there a module for either of these tools?

I think so. I have never tryed yet, but it is likely that dnaapler takes the assembled genome *.fasta emmited by any assembler used in nf-core bacass (dragonflye, unicycler, miniasm, ...).

Daniel-VM avatar Mar 19 '24 09:03 Daniel-VM

I can work on a dnaapler module if that would help?

lborcard avatar Mar 19 '24 10:03 lborcard

Sure 💯 . Please add a git issue for dnaapler implementation ;).

Daniel-VM avatar Mar 19 '24 10:03 Daniel-VM

i added it to the list

lborcard avatar Mar 19 '24 10:03 lborcard