atacseq icon indicating copy to clipboard operation
atacseq copied to clipboard

Some samples aren't processed

Open chbk opened this issue 3 years ago • 2 comments

In the MultiQC report, only one of the samples appears in the following sections:

  • MERGED LIB: PICARD
  • MERGED LIB: deepTools: Read Distribution Profile after Annotation
  • MERGED LIB: HOMER peak annotation
  • MERGED REP: HOMER peak annotation

Compare:

a b c

With:

d

chbk avatar Feb 08 '21 17:02 chbk

Upon further investigation, it appears only one of the files in the channels is processed. This is because the input channels do not have the same lengths: https://github.com/nf-core/atacseq/blob/1b3a832db5a53c92c2c89a4d6d79455e860461ad/main.nf#L958 https://github.com/nf-core/atacseq/blob/1b3a832db5a53c92c2c89a4d6d79455e860461ad/main.nf#L959

A workaround would be:

tuple val(name), path(bam), path(fasta) from ch_mlib_rm_orphan_bam_metrics.combine(ch_fasta)

chbk avatar Feb 10 '21 13:02 chbk

Hi @chbk ! Thank you for creating this issue. This is quite odd because the the full-tests we run on pipeline release have the correct sections in the MultiQC report. But I agree that something isn't clearly right. I think it may be better to troubleshoot on Slack in real-time. If you aren't a member you can join here and post on the #atacseq channel.

drpatelh avatar Feb 10 '21 14:02 drpatelh

Hi @chbk ! We are about to release a much updated version of the pipeline that has been completely refactored to be written in Nextflow DSL2. When this is released, it would be great if you can let us know if the problem still persists. I will close this issue for now.

drpatelh avatar Nov 18 '22 12:11 drpatelh