Houliang Qi
Houliang Qi
There are some code smells which we may pay attention to.
> I think you can do > gocron.Every(1).Day().At("8:00").Do(task_start) > to start the task > > gocron.Every(1).Day().At("18:30").Do(task_stop) > to stop the task LGTM, prefect!
Fantastic job, only minor question, why not just using thread pool like this `ThreadPoolExecutor(int corePoolSize, int maximumPoolSize, long keepAliveTime, TimeUnit unit, BlockingQueue workQueue, ThreadFactory threadFactory)` rather than recreate the DynamicThread?
> Agreed. But I am not sure what side effect it may cause, so we may discuss about it in another issue. OK~
I think it is necessary to have a mechanism to control memory usage to avoid OOM, even if it may cause performance degradation, after all, usability is more important than...
We also need this feature very much. Is there a preliminary implementation of this feature?