Justin Kiggins

Results 63 comments of Justin Kiggins

Thanks for the input Chris! Agreed that we don't need to do hasty changes... I completely agree with number 1: the NWB branding should take precedence and whatever PyNWB uses...

I've been looking more closely at exdir & I'll add a +1 to @jeffteeters's suggestion. They seem to have done most of the hard work here & the api is...

hey @mattcai can you review this PR? it would be nice to get it in to 0.3.0 if its ready

This needs to wait on a new skimage release.

After consultation with @shanaxel42 and @ttung, proposing the following... Let's make sure that we support 3D where underlying algorithms support 3D, but we shouldn't develop new 3D algorithms. Practically, as...

LocalMaxPeakFinder, which wraps the 2D `skimage.feature.peak_local_max` https://spacetx-starfish.readthedocs.io/en/latest/api/spots/index.html#starfish.spots.FindSpots.LocalMaxPeakFinder

Thanks to @ttung for diving in and noting that I was wrong about LocalMaxPeakFinder (silly me for relying on our docs). Details here: https://github.com/spacetx/starfish/issues/1679