Results 445 comments of netwolfuk

Wow, thanks for the speedy response. I've been thinking about this over the weekend realised now that my request was very poorly worded. Inside the second stream, I am streaming...

Thanks Thomas for taking the time to respond. I will look into that. It's just that your API is much nicer to deal with ;-) Sorry to have wasted your...

Yes. You're right. It does not use the variables from the payload. It feels like a it's a useful feature but be aware that will leak your credentials if you...

I'm starting to like this idea BTW. I'll have a look into the code and see how easy it is to inject the resolver into the auth code. Thanks for...

I had a look at this and it's quite a large refactor to make the resolver available to the authentication factory. I will make this as milestone 1.2 as I...

BTW, I just remembered that the header support does [support variable resolution](https://github.com/tcplugins/tcWebHooks/blob/master/tcwebhooks-core/src/main/java/webhook/WebHookImpl.java#L440-L446). So if you want to craft an *Authorization* header using [header support](https://github.com/tcplugins/tcWebHooks/wiki/Custom-Headers), you could do that until I...

Thanks for the thorough bug report. I'll try to take a look over the weekend

Hi @buumi. Thanks so much for your patience on this. We have a new baby in the house, and suddenly my spare time has disappeared. I've imported your template (thanks...

Perhaps your change list consists of more than one VCS? I don't think I've ever tested that.

Hi @kichnan The code is supposed to do the serialisation for you here: https://github.com/tcplugins/tcWebHooks/blob/2675215f3e641e90e3fc1f7a284397b62f86f4c3/tcwebhooks-core/src/main/java/webhook/teamcity/payload/format/WebHookPayloadJsonTemplate.java#L79 Yes, those commands are provided by the plugin here https://github.com/tcplugins/tcWebHooks/blob/1.1.x.x/tcwebhooks-core/src/main/java/webhook/teamcity/payload/util/WebHooksBeanUtilsVariableResolver.java There is an escape JSON function...