Johann Pardanaud
Johann Pardanaud
I tried to highlight a section of code containing some comments, but they were stripped. Here's a patch to reproduce the issue in the HTML tests: - [download the patch](https://www.icloud.com/iclouddrive/0f6wgDZgK9CXg15GGqig7DhtQ#highlighted-comment)...
### Context I would like to decorate a `RedisCluster` instance. The decorator would only act as a proxy and measure the time spent in some specific methods. I already did...
For example, the `Nesk\Puphpeteer\Resources\Page::addScriptTag()` method takes an array shape: https://github.com/rialto-php/puphpeteer/blob/a3c30bce7eb95d0c63373426cad06111d3b6bca6/src/Resources/Page.php#L33 Here, as written, all the keys are required. But if we look Puppeteer's documentation, [none of the keys are required](https://pptr.dev/#?product=Puppeteer&version=v7.1.0&show=api-pageaddscripttagoptions)....
Sometimes we have weird issues due to the different environments of our users: #114 #84 #65 Debugging those environments is a real pain. What we could do is provide an...
Currently, PuPHPeteer locks the minor version used for Puppeteer because its exports aren't applying semver (see #22) and can change between releases. Once the exports are no longer an issue,...
The following JS function will throw an error with the message "require is not defined": ```php JsFunction::createWithBody("require('fs')"); ``` This is because JS functions in PuPHPeteer are created with the `Function`...
The socket layer was written with little knowledge about socket management, it would highly benefit from a rewrite. First, those issues must be fixed: - [ ] Payloads sent through...
The contribution guide should explain the architecture of the code, it's something really obscure to anyone and it slows down everybody who wants to contribute.
# The problem Currently, it's up to the implementation to determine if the instruction should be `await`ed or not. For example, [PuPHPeteer always `await` the instructions](https://github.com/nesk/puphpeteer/blob/95cb6f2211b3acae9dfb5430610b551f87a51e9d/src/PuppeteerConnectionDelegate.js#L38). However, `await`ing all the...