nerfstudio icon indicating copy to clipboard operation
nerfstudio copied to clipboard

Published 20 hours ago • verified publisher icon nerfstudio-project

Fix SH

Open jkulhanek opened this issue 11 months ago • 3 comments

I think there is a bug in the SH pytorch impl. This PR should fix it. Please take a look to see if it's correct. I took the correct implementation from ingp.

jkulhanek avatar Mar 20 '24 14:03 jkulhanek

Just to cite Inria gaussian splatting's implenentation: https://github.com/graphdeco-inria/gaussian-splatting/blob/main/utils/sh_utils.py

jb-ye avatar Mar 20 '24 17:03 jb-ye

Inria’s impl us also correct. The ingp’s one, however, supports more degrees.

jkulhanek avatar Mar 21 '24 11:03 jkulhanek

Just want to revisit this topic: Shall we remove SH evaluation in nerfstudio, and use the one from gsplat library? So it minimize our maintenance effort. @kerrj

jb-ye avatar Apr 19 '24 18:04 jb-ye