dijo icon indicating copy to clipboard operation
dijo copied to clipboard

Let first calendar day always start on Monday

Open matze opened this issue 3 years ago • 5 comments

Shift first day of the month so that the first calendar day is always Monday. Otherwise, week days are not at a constant position month to month which is counter-intuitive to how normal calendars work.

Question is if the first day of the week should be configurable or (somehow) be fetched from the user's locale.

matze avatar Jul 21 '20 14:07 matze

This PR is looking really good, thank you for showing interest in dijo!

I did have the dates offset originally, but I felt a certain disconnect with how WEEK mode interacts with this. Currently, WEEK summarizes each row of the month, because there is no offset.

With the offset in place, 1 line in WEEK mode would not correspond the 1 line in DAY mode, but rather a bit of two lines.

oppiliappan avatar Jul 21 '20 15:07 oppiliappan

With the offset in place, 1 line in WEEK mode would not correspond the 1 line in DAY mode, but rather a bit of two lines.

That's true in a way but somehow up to now I did not see such strong connection between both modes. Hmm, one could make it configurable but that means more options which means more failure modes and complaints. No idea what to do now ;-)

matze avatar Jul 21 '20 16:07 matze

So currently week mode tabulates from whatever day of the month was the first? E.g. thursday to wednesday? That seems strange

Would it be possible to do the offset and show the previous month's contribution, maybe with a different terminal background color?

dmadisetti avatar Jul 22 '20 16:07 dmadisetti

might be able to resolve with a configuration file and leave it up to the user #52

jjn2009 avatar Jul 25 '20 06:07 jjn2009

Is it possible to implement this as an option now that the configuration file has been merged?

Xyzer avatar Apr 09 '21 09:04 Xyzer