Marcus Griep

Results 43 comments of Marcus Griep

It looks like technically `Message` is already object safe—we have a `const` in the `message.rs` file to assert that it is safe to put in `dyn`. However, I am in...

Watching this as well. * Query mode seems a bit off, often showing that there are no results when there very much should be, requiring "reset query" and recreating the...

Indeed. I have this scoped for some work over the next week.

This is largely complete (pending release). I've opted to defer updating `aliri_reqwest` until after `reqwest-middleware` releases their update to use `reqwest 0.12`, at which point all the main crates (except...

Thank you for putting together a PR to kick this off. Indeed I too have been waiting a bit for some movement in other ecosystem areas before putting in an...

Closing in favor of #70. Now that `reqwest` was also updated, there was greater benefit to moving this along. Still waiting for `tonic` and `reqwest-middleware` for other parts. Thanks for...

It is possible to get to those claims. Though the _fields_ aren't public, the items can be accessed via the `jwt::CoreClaims` impl on `BasicClaimsWithScope` (`token.claims().sub()`). I don't think there is...

Unfortunately, this is not possible when also providing the borrowed form of the type. Converting a string slice into the borrowed type _requires_ the use of unsafe. I discuss this...

The difference between `MyWrapper` and `MyWrapperRef` is analagous to the difference between `String` and `str` or `PathBuf` and `Path`. You certainly can pass around a `&String`, but that looks weird,...

I think that I would need to better understand the use case for implementing `Borrow`. In the vast majority of cases, the `Borrow` and `Borrow` implementations cover the use cases...