Marcus Griep

Results 43 comments of Marcus Griep

Thanks for preparing the use case for me. I think that, in these situations, I generally defer to `.as_str()`, as in: ```rust let my_object_opt = my_objects.get(some_type.some_field.as_str()); // or let my_object_opt...

Thanks for the report. I've put in a fix for this. I'll aim to get it merged in and a new version released for you.

I'm good with a PR for that. Thanks!

Thanks for this. I'll be a bit slow on review due to other commitments, but should be able to get an initial review in the next couple of days.

I would love to see this too. For the first iteration, I didn't have a clear model of how to do it safely, especially with the myriad things that a...

> This was kind of an unexpected foot gun because the fields in the struct were public, so I assumed there wouldn't be any special business logic involved in manipulating...

> I'm going to try and get a PR through today if that's cool. Great. I look forward to seeing it posted!

> Personally, I see follows_from as an equivalent of span links (as is already used by this library) and more general than the parent-span relationship. In the example of a...

I wonder if there's value in more explicit boxing of `Status`, or if `Status` should internally box in order to reduce its size.

Could this be implemented as something with a label? Such as `renovate:embargo`? Then, if that label were found on the pull/merge request, when Renovate would want to open up a...