Wenchen Li

Results 9 issues of Wenchen Li

This would supersede #795 and #841: - Close #795 - Close #841

I figured doing the source tags like this: ```html ``` is better than this and switch the `src` manually: ```html ``` But it doesn't seem to work with me. It...

known issue

### Describe the Bug I personally think that in a "controlled" setup, setting nodes from within the code shouldn't trigger `onNodesChange`; just like how in a react controlled form field,...

I think it should only emit `'dimensions'` changes to `onNodesChange` when it's not `forceUpdate` from within `updateNodeDimensions`. This is an attempt to fix #2405.

I think it might be better to not move the canvas to be the direct child of the body? or at least offer an option? https://github.com/8thwall/web/blob/master/xrextras/src/fullwindowcanvasmodule/full-window-canvas-module.js#L132

This could come in handy when the mask image is saved as RGB

we might want to update the node-sass version in the `package.json`, it's failing on some newer node environments. if we agree to this, I could do that. I feel like...

approved