Neo Liang

Results 31 comments of Neo Liang

Hi @tedteng , thanks for your comments. I tried your proposal but seems not working from my side, could you please check and confirm? thanks! ![image](https://user-images.githubusercontent.com/42594392/100689953-813e1900-33c0-11eb-9018-355f2212b534.png) ![image](https://user-images.githubusercontent.com/42594392/100689967-89965400-33c0-11eb-99c4-2b945442999c.png) -Neo

the issue seems intermittent - i tried sometime later today and it's success without problem, for same shoot, same node ![image](https://user-images.githubusercontent.com/42594392/104445873-a388a080-55d4-11eb-88d3-7d416b1ff645.png)

> I prepare a fix for this issue, but I don't have permission to push to this repo. can somebody grant me permission please fork this repo to your personal...

@shaoyongfeng why you are using such an old version of gardenctl??? ![image](https://user-images.githubusercontent.com/42594392/137892403-1dfa3b63-421b-4b0e-b88d-da8c2fec009c.png)

i will work on `curl` part in https://github.com/gardener/gardenctl/issues/273

this repo has been deprecated - why still need attention? CC @donistz

see my comments in https://github.com/gardener/gardenctl/pull/270/commits/663bc2eac319070fbf1ffd002969c326b09d5cde#r475304808

cleaning duplicate code as comment is https://github.com/gardener/gardenctl/issues/269#issuecomment-678987072 is absolutely good and correct. As discussed time and time again, please make sure `gardenctl target -g xxx -s xxx -t xxx` still...

lint check is done. for tests: - identify test cases we are missing - whenever new code is introduced, the definition of done should also require test cases.