gardenctl icon indicating copy to clipboard operation
gardenctl copied to clipboard

Use go API instead of local command execution where possible

Open petersutter opened this issue 4 years ago • 5 comments

In the code you often see stuff like

  • ExecCmdReturnOutput("bash", "-c", "curl <something>")
  • ExecCmdReturnOutput("bash", "-c", "export KUBECONFIG="+currentConfig+"; kubectl <something>") etc.

Instead of using curl and kubectl, use go APIs where possible

petersutter avatar Aug 21 '20 13:08 petersutter

/assign

tedteng avatar Aug 22 '20 01:08 tedteng

It may be good to evaluate how many times we are using curl/kubectl and evaluate if we need to split this into two tasks

dansible avatar Aug 24 '20 13:08 dansible

i will work on curl part in https://github.com/gardener/gardenctl/issues/273

neo-liang-sap avatar Aug 25 '20 01:08 neo-liang-sap

will working on ExecCmdReturnOutput("bash", "-c", "export KUBECONFIG="+currentConfig+"; kubectl <something>") insteading of using kubectl, use go APIs where possible . https://github.com/gardener/gardenctl/issues/281

tedteng avatar Aug 25 '20 12:08 tedteng

/assign

tedteng avatar Aug 26 '20 02:08 tedteng