Rene Saarsoo

Results 487 comments of Rene Saarsoo

Thanks for the effort. #### Regarding your main question about colon and square-bracket syntax. - For brackets, adding `extraParens: ['[]']` should do the trick. See for example in `n1ql.formatter.ts` -...

Regarding quote types, see: https://github.com/sql-formatter-org/sql-formatter/blob/master/src/lexer/regexFactory.ts#L99 The `-qq` and `-bs` suffixes at the end of quote types define what sort of escaping (if any) is used inside the quotes.

Some comments about wiki updates: - [Parameters page](https://github.com/sql-formatter-org/sql-formatter/wiki/parameters) says that Snowflake supports `$1` parameters and links to [select docs](https://docs.snowflake.com/en/sql-reference/sql/select.html#parameters). I'm pretty sure these are something else than parameters one would...

Thanks. Updated the docs for Snowflake window functions syntax.

BTW. I would appreciate if you didn't do further force-pushes to this branch. They make it hard to tell what has changed.

Regarding the formatting of `:` operator. I made a change to make the customization of formatting simpler: #466 One should now be able to simply add this to SnowflakeFormatter class:...

Also added escaping of keywords, so the `$` character in function names should no more pose a problem: #473

If you want, feel free to delete these accidental commits and force-push the result. You'll just need to: ``` git rebase -i 152bd48 # delete all the commits besides the...

> Is there an option to define how identifiers are allowed to look like? Yep, there are two options for that: - `identTypes` describes quoted identifiers (with all characters allowed...

OK, let the tests be for now as they are. My main concern was with the `SET SCHEMA` test. Others are not that big of a deal.