Neil Pilgrim
Neil Pilgrim
@Gopinath-Mahendiran I've not looked through every change, since your commits aren't tidied as per the main Zulip commit guidelines, and they're not passing tests - which may be related. Otherwise,...
@sundanc It seems that this is not passing the tests; some of this is related to a common error, but others are down to you - if you don't understand...
I left some notes in the channel, but getting the first commit merged with an adjusted key would be great as a first step. The remainder could be useful, particularly...
@Niloth-p Thanks for the quick PR adjust, which I only just noticed. The only change I made was to make it clearer that the 'hint' being referred to is an...
@Ajnus Just a quick note re testing in general - these can all be run locally, as per the development notes in the README. In particular there is `tools/check-branch`, for...
@rsashank Thanks for the updates :+1: I just pushed back here with the following changes: - capitalized the Exception Popup (similar to Niloth's changes) in the help - removed an...
@rsashank I started a review, but will leave that pending until I hear back to confirm the implementation details I noted in #zulip-terminal.
@Gopinath-Mahendiran It would help to know how you tested this - not everything is applicable here, but you didn't fill out the self-review checklist, for example.
The other outstanding update is the zuliprc docs; fine details will depend on a few final decisions re the behavior, but a provisional adjustment to the README would be a...
@Niloth-p Thanks for the rebase :+1: I agree about the narrowing category, certainly until we consider multi-categories (if we do). It would seem that n/p would also be best in...