Neil Pilgrim
Neil Pilgrim
@sahith-ch I left feedback in the channel, since it may be easier to discuss there, and there's a lot of background discussion that I'm not sure if you've read?
Just a note that re the commits above, you only need to mark one commit as fixing the issue, and you can leave that for now until we reach a...
@Gopinath-Mahendiran I reviewed zulip/python-zulip-api#866, and of course this PR will depend on those changes to at least some extent. Generally this PR would be easier to follow if you can...
I'm following up on this now.
@Niloth-p For some more direct feedback here, this looks to work OK, though I've not reviewed the code as there are other PRs underway! Points to consider: - `?`, `n`/`p`...
@Niloth-p Thanks for sticking with these improvements - I agree they are definitely helping :+1: Following on from my summary in #1524, my main concern here is that the categories...
@Niloth-p Thanks for this and your slight update :+1: It's definitely nuanced between the two but let's move on and get this merged for now, and we can always return...
@Niloth-p Do you have the bandwidth to give some thoughts on this, compared to your approach in #1543 ?
I don't use a mac so this is difficult for me to confirm personally. Which terminal emulators have you tested this on? My understanding is that depending on the terminal...
@Khushiyant I was referring to the application you're using to run `zsh` (which itself is a shell), so that doesn't quite answer my question.