Nic Cope

Results 846 comments of Nic Cope

@crossplane/crossplane-maintainers @vfarcic - FYI, see https://github.com/crossplane/crossplane/pull/5450#issuecomment-2143269862 for some planned changes to https://github.com/crossplane/crossplane/blob/v1.16.0/design/one-pager-fn-claim-conditions.md based on what we've found at implementation time. Let us know ASAP if you have any questions or...

> During testing, I noticed that events quickly get rate limited. @dalton-hill-0 Interesting. We definitely don't want to increase the event rate limit. This would only be an issue in...

> This doesn't seem to be unique to this PR, but I thought it was worth mentioning. We may need to document this somewhere. @dalton-hill-0 Could you raise an issue...

@dalton-hill-0 I just merged https://github.com/crossplane/crossplane-runtime/pull/738, I'm guessing this needs to be updated to include the latest runtime to get the build to pass.

For future readers, especially folks implementing new providers, I'd recommend not implementing cross resource references for the reasons @turkenh outlines above. https://github.com/crossplane/crossplane/blob/v1.16.0/design/design-doc-composition-functions-extra-resources.md https://github.com/crossplane-contrib/function-extra-resources/tree/main Instead, I recommend using composition functions. A...

Worth noting that we'll release `crossplane beta convert` in v1.15, which has support for migrating a `ControllerConfig` to a `DeploymentRuntimeConfig`. Maybe that's enough, if we give folks enough notice?

Reopening this and removing the good first issue tag. @NeerajNagure got the ball rolling in https://github.com/crossplane/crossplane/pull/5682, but I think we need to do a more thorough scan for immutable fields...