Nic Cope

Results 846 comments of Nic Cope

@dalton-hill-0 I spent a little time on this today and put together a sketch at https://github.com/crossplane/crossplane/pull/5523. It doesn't actually work end-to-end, but hopefully it's enough to communicate what I'm thinking...

> Got a design question for you. @dalton-hill-0 I'm struggling with this one a bit. Here's what I'm considering. We don't want to emit a `Normal` event every time a...

@dalton-hill-0 Here's an idea that came to mind while writing the novel above. ```go func (f *Function) RunFunction(ctx context.Context, req *fnv1beta1.RunFunctionRequest) (*fnv1beta1.RunFunctionResponse, error) { rsp := response.To(req, response.DefaultTTL) oxr, _...

> I like the approach you outlined above, but we may need to make a couple of modifications. @dalton-hill-0 Ack. > Summary: Standard API does not expose a way to...

> IMO this would be fine for the initial implementation (assuming we can set status conditions in the fatal path). If desired in the future, we can add logic that...

> I think what we had discussed previously will solve this @dalton-hill-0 I agree, but that approach would mean we'd have to address what I described in https://github.com/crossplane/crossplane/pull/5450#issuecomment-2038841918, right? If...

> I think not allowing the function author to set custom conditions in a fatal case could lead to a confusing claim state for the user. @dalton-hill-0 we already have...

> Communicate fatal errors by just [returning an error](https://grpc.io/docs/guides/error/) from the RunFunction method. Actually, maybe this doesn't make sense. The function would need to return a valid `RunFunctionResponse` in order...

@dalton-hill-0 Okay, I spent today thinking about this design. Here's where I'm at. I agree we should add `conditions`, distinct from `results`, to `RunFunctionResponse`. I think we should keep `results`...

@dalton-hill-0 Thanks! I can update the design doc to match our latest thinking. Maybe I'll wait until you've taken another pass on implementation though, just to make sure we're confident...