Nic Cope
Nic Cope
Looks like the E2E tests are passing pretty reliably now. The only thing blocking moving this out of draft is writing some more unit tests.
> So, I would need them to be importable @turkenh How would you feel about duplicating them to start with? We could then consolidate later. I'm hopeful we can get...
I've moved this out of draft. It should be ready for final review. @sttts Do you want to do another pass? @turkenh Would you be interested in reviewing/approving on behalf...
@turkenh Thanks for approving! I can't proceed until https://github.com/crossplane/crossplane-runtime/pull/689 is also approved. Could you take a look? It's pretty much just deleting code.
I've seen `TestCompositionInvalidComposed` fail a few times recently when running local tests. I've noticed that it does sometimes successfully create the `XChild` composed resource - I don't think it's supposed...
https://app.buildpulse.io/@crossplane/crossplane - For the record, this is now tracking our E2E flakes.
This sounds like one of the problems described in https://github.com/crossplane/crossplane/issues/4047: > Patches will never remove a field from an object; they're only additive. I think the solution is as proposed...
I think the way forward here is to use composition functions. https://docs.crossplane.io/v1.14/concepts/composition-functions/ Composition functions use server-side apply, and will thus handle deleted fields correctly. With v1.14 we're introducing a `crossplane...
CC @dalton-hill-0 @TerjeLafton @jbw976 - Just an FYI as this is tangentially related to designs you've all been working on.
If anyone from the community wants to give this a shot, I'd be supportive. I think it would require a little experience with Crossplane though.