Nic Cope

Results 846 comments of Nic Cope

> I would handle it like shell variables passed to subprocesses: A container in a pod cannot modify a ConfigMap by changing the environment variable. That sounds reasonable. > In...

@MisterMX and I just spent an hour discussing this design on a Zoom call. We sketched out something like the below. I've taken a shot at cleaning it up and...

> How are configs grabbed via environmentConfigRefs and environmentConfigSelectors merged together? It seems we might have different understandings of how this would work. Are you thinking that selectors would select...

> I agree with you. For now it should be enough to log the environment. Maybe we can find a solution once we have gathered some experience. 💯 > Maybe...

> However, I would store the references in the XR, rather than the Composition because the list of references is unique to the XR+Composition combination. As yes, good point I...

> I understand it is safer to restrict it to a crossplane native object, but how can we add to the EnvironmentConfig dynamically ? I guess your answer to that...

> Having EnvironmentConfig be dynamically updated may result in harder to follow compositions if the value were not easily traceable Agreed. I'm a little worried about this but happy to...

@muvaf Should we move forward with getting this merged? Maybe @turkenh (or someone else from your team) could do a review pass?

@muvaf This has been in draft for a while and I'm doing a bit of PR backlog cleanup so I'm going to close it. Feel free to reopen if/when you...

> DCO is broken after GitHub suggestion-based commit. You'll need to add 'Signed-off-by' to them I recommend squashing these all into one commit, and signing that one.